Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add card-specific feedback button styling #940

Merged
merged 9 commits into from
Sep 9, 2021
Merged

Add card-specific feedback button styling #940

merged 9 commits into from
Sep 9, 2021

Conversation

nmanu1
Copy link
Contributor

@nmanu1 nmanu1 commented Sep 7, 2021

Add card-specific styling for thumbs up/down feedback buttons on all results cards.

J=SLAP-1544
TEST=manual

Smoke testing to see if buttons match mock for each card

@coveralls
Copy link

coveralls commented Sep 7, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 8.053% when pulling 77614ba on dev/feedback-button-styling into 77948f2 on feature/feedback-buttons.

@nmanu1 nmanu1 requested review from oshi97 and yen-tt September 9, 2021 18:29
yen-tt
yen-tt approved these changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@yen-tt yen-tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@nmanu1 nmanu1 merged commit 692f9f5 into feature/feedback-buttons Sep 9, 2021
@nmanu1 nmanu1 mentioned this pull request Oct 12, 2021
Merged
nmanu1 added a commit that referenced this pull request Oct 12, 2021
@nmanu1
Add generic thumbs up/down (#973)
d3d591b 
Add generic thumbs up/down feedback buttons and analytics to all cards (#938, #939, #940).

- Include a `feedback` config option in `dataForRender` so user can specify if feedback buttons should appear on the card or not.
- Create a shared partial for the buttons that is used in all cards, including direct answer cards
- Update analytics for direct answer feedback with additional event attributes.

J=SLAP-1544, 1545
TEST=manual

Smoke testing to see if thumbs up/down buttons function as expected on all cards and send analytics.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yen-tt yen-tt yen-tt approved these changes

@tmeyer2115 tmeyer2115 Awaiting requested review from tmeyer2115

@oshi97 oshi97 Awaiting requested review from oshi97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nmanu1 @coveralls @oshi97 @yen-tt